Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(resource): display permissions (DEV-454) #660

Merged
merged 15 commits into from Feb 17, 2022
Merged

feat(resource): display permissions (DEV-454) #660

merged 15 commits into from Feb 17, 2022

Conversation

kilchenmann
Copy link
Contributor

resolves DEV-454

@kilchenmann kilchenmann self-assigned this Feb 15, 2022
@kilchenmann kilchenmann marked this pull request as draft February 15, 2022 22:25
@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request refactor Refactor or redesign labels Feb 16, 2022
@kilchenmann kilchenmann marked this pull request as ready for review February 16, 2022 06:52
mdelez
mdelez requested changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the test isn't crucial but it may be nice to have if we're going to be working with permissions at a later point in time so we know that this new component still works

src/app/workspace/resource/permission-info/permission-info.component.ts Outdated Show resolved Hide resolved
src/app/workspace/resource/permission-info/permission-info.component.spec.ts Show resolved Hide resolved
mdelez
mdelez approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@kilchenmann kilchenmann merged commit 13a3a49 into main Feb 17, 2022
@kilchenmann kilchenmann deleted the wip/dev-454-res-permissions branch February 17, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees

@kilchenmann kilchenmann

Labels
bug A bug fix enhancement New feature or request refactor Refactor or redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @mdelez