feat(add-link-resource-button): Add Link Resource Button (DEV-404) #645
Conversation
…en clicking on add new link value button while creating a resource
…opriate link resource class
… and create the resource
…nd fixes link value tests
…to the first list item
…aceholder, create new resource button and the title of the create new resource form
| <form [formGroup]="propertiesForm" (ngSubmit)="onSubmit()"> | ||
| <!-- upload file --> | ||
| <app-upload *ngIf="hasFileValue" | ||
| [parentForm]="propertiesForm" | ||
| [representation]="hasFileValue" | ||
| (fileInfo)="setFileValue($event)"> | ||
| </app-upload> | ||
|
|
||
| <app-select-properties #selectProps | ||
| [ontologyInfo]="ontologyInfo" | ||
| [resourceClass]="resourceClass" | ||
| [properties]="properties" | ||
| [parentForm]="propertiesForm" | ||
| class="select-properties"> | ||
| </app-select-properties> | ||
| <div class="form-panel form-action"> | ||
| <span> | ||
| <button mat-button type="button" (click)="closeDialog.emit()"> | ||
| {{ 'appLabels.form.action.cancel' | translate }} | ||
| </button> | ||
| </span> | ||
| <span class="fill-remaining-space"></span> | ||
| <span> | ||
| <button mat-raised-button type="submit" color="primary" class="form-submit" [disabled]="!propertiesForm.valid"> | ||
| {{ 'appLabels.form.action.submit' | translate}} | ||
| </button> | ||
| </span> | ||
| </div> | ||
| </form> |
There was a problem hiding this comment.
Is the create-link-resource.component the same as in the second step of resource-instance-form? Does it make sense to duplicate the code?
There was a problem hiding this comment.
@kilchenmann they're quite similar but the resource-instance-form has a back button to go back to the first step and it redirects the user to the created resource after it's been created. resource-instance-form uses an array of ResourceClassDefinition whereas create-link-resource does not use an array. We could try to condense it all into one component but we might have a lot of ugly if statements to hide/show relevant parts of the component depending on what the user is doing. What are your thoughts?
There was a problem hiding this comment.
Thanks for your response. That's true. Sooner or later the resource-instance-form will anyway have only one form (without the first step) and the back button will not be needed anymore. I would appreciate it if we do not have too many of the same forms.
There was a problem hiding this comment.
Should I refactor in this PR or another one?
There was a problem hiding this comment.
What do you prefer? I think it should be resolved in this PR... or what will be the simplest solution?
There was a problem hiding this comment.
after speaking with André, we decided to do the refactor in another PR because the create-resource-instance form will change in the future
resolves DEV-404