fix(ontology): support subproperty in ontology editor (DEV-332) #643

kilchenmann · 2022-01-24T22:35:27Z

resolves DEV-332

mdelez

Everything works well for me! I just have a few remarks/questions

src/app/project/ontology/default-data/default-properties.ts

src/app/project/ontology/ontology.service.ts

kilchenmann added 2 commits January 24, 2022 23:30

fix(ontology): support subproperty in ontology editor (DEV-332)

a764e8a

refactor(ontology): delete console.log

621c836

kilchenmann self-assigned this Jan 24, 2022

kilchenmann added bug A bug fix enhancement New feature or request labels Jan 24, 2022

kilchenmann added 2 commits January 25, 2022 12:01

fix(ontology): bug fix in part of prop

f6b4855

Merge branch 'main' into wip/dev-332-ontology-subproperties

a56c587

kilchenmann requested a review from mdelez January 25, 2022 11:02

kilchenmann added 7 commits January 28, 2022 15:10

feat(ontology): add unsupported prop types to list of default

c426b7f

style(ontology): display hint in case of unsupported prop type

bbb9e0f

feat(ontology): function to get super and default prop

d6bfa28

style(ontology): display hint in case of unsupported prop type

8ccb44e

refactor(ontology): clean up code

58aeac9

feat(ontology): support subproperties (DEV-332)

e85d130

chore(deps): bump js-lib to latest

eb88237

kilchenmann added the dependencies Pull requests that update a dependency file label Jan 28, 2022

kilchenmann added 2 commits January 28, 2022 17:33

refactor(ontology): clean up code

8c41be5

test(ontology): fix tests

ddbb5f7

mdelez requested changes Jan 31, 2022

View reviewed changes

src/app/project/ontology/default-data/default-properties.ts Outdated Show resolved Hide resolved

src/app/project/ontology/ontology.service.ts Show resolved Hide resolved

src/app/project/ontology/ontology.service.ts Show resolved Hide resolved

refactor(ontology): clean up default props

8512f2f

kilchenmann requested a review from mdelez January 31, 2022 21:26

mdelez approved these changes Feb 1, 2022

View reviewed changes

kilchenmann merged commit c838043 into main Feb 1, 2022

kilchenmann deleted the wip/dev-332-ontology-subproperties branch February 1, 2022 09:56

mdelez mentioned this pull request Jul 29, 2022

fix(property-form): App changes "salsah-gui:List" to "salsah-gui:Pulldown" (DEV-1089) #783

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ontology): support subproperty in ontology editor (DEV-332) #643

fix(ontology): support subproperty in ontology editor (DEV-332) #643

kilchenmann commented Jan 24, 2022

mdelez left a comment

Navigation Menu

fix(ontology): support subproperty in ontology editor (DEV-332) #643

fix(ontology): support subproperty in ontology editor (DEV-332) #643

Conversation

kilchenmann commented Jan 24, 2022

mdelez left a comment

Choose a reason for hiding this comment