Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ontology): support partOf value to create book res class (DEV-180) #634

Merged
merged 11 commits into from Jan 18, 2022
Merged

feat(ontology): support partOf value to create book res class (DEV-180) #634

merged 11 commits into from Jan 18, 2022

Conversation

kilchenmann
Copy link
Contributor

resolves DEV-180

@kilchenmann kilchenmann self-assigned this Jan 14, 2022
@kilchenmann kilchenmann added dependencies Pull requests that update a dependency file enhancement New feature or request labels Jan 14, 2022
@kilchenmann kilchenmann marked this pull request as draft January 14, 2022 07:51
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jan 14, 2022 •
edited

we have to wait for new API release with fixed bug dasch-swiss/dsp-api#1978

@kilchenmann kilchenmann marked this pull request as ready for review January 18, 2022 07:38
@kilchenmann kilchenmann requested review from mdelez and removed request for mdelez January 18, 2022 07:38
@kilchenmann
Copy link
Contributor Author

@mdelez you'll need latest release of DSP-API (or main branch) if you want to test this feature. Please feel free to correct the new section in the documentation.

mdelez
mdelez approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me!

@kilchenmann
Copy link
Contributor Author

Thank you @mdelez for updating the docs

@kilchenmann kilchenmann merged commit 3051a67 into main Jan 18, 2022
@kilchenmann kilchenmann deleted the wip/dev-180-ontology-support-part-of branch January 18, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees

@kilchenmann kilchenmann

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @mdelez