Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(properties): ckEditor Internal Links (DEV-118) #591

Merged
merged 3 commits into from Nov 18, 2021
Merged

feat(properties): ckEditor Internal Links (DEV-118) #591

merged 3 commits into from Nov 18, 2021

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Nov 17, 2021

resolves DEV-118

@mdelez mdelez added the enhancement New feature or request label Nov 17, 2021
@mdelez mdelez self-assigned this Nov 17, 2021
@mdelez mdelez changed the title feat(properties): ckEditor Internal Links (dev-118) feat(properties): ckEditor Internal Links (DEV-118) Nov 17, 2021
kilchenmann
kilchenmann reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@kilchenmann kilchenmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the appHtmlLink directive to the text-value-as-html.component.ts in this PR?

@mdelez
Copy link
Collaborator Author

mdelez commented Nov 18, 2021

Could you also add the appHtmlLink directive to the text-value-as-html.component.ts in this PR?

done in b057433

@mdelez mdelez merged commit cac988b into main Nov 18, 2021
@mdelez mdelez deleted the wip/dev-118-ckeditor-internal-links branch November 18, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilchenmann kilchenmann kilchenmann approved these changes

Assignees

@mdelez mdelez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdelez @kilchenmann