Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: iiif config refactor (DEV-162) #573

Merged
merged 1 commit into from Nov 3, 2021
Merged

refactor: iiif config refactor (DEV-162) #573

merged 1 commit into from Nov 3, 2021

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Nov 3, 2021

resolves DEV-162

@mdelez
refactor: refactors upload-file service to use the string generated i…
f4dfb7a 
…n the iiif-config file and changes the public class members in app-init service to private with getters.
@mdelez mdelez self-assigned this Nov 3, 2021
@mdelez mdelez requested a review from subotic November 3, 2021 14:30
subotic
subotic approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@mdelez mdelez merged commit c39ca5b into main Nov 3, 2021
@mdelez mdelez deleted the wip/dsp-162-iiif-config-usage-refactor branch November 3, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees

@mdelez mdelez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdelez @subotic