Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(value): refactor boolean value (DEV-98) #554

Merged
merged 13 commits into from Oct 20, 2021
Merged

feat(value): refactor boolean value (DEV-98) #554

merged 13 commits into from Oct 20, 2021

Conversation

kilchenmann
Copy link
Contributor

resolves DEV-98

@kilchenmann kilchenmann self-assigned this Oct 18, 2021
@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request refactor Refactor or redesign styling Update style; no production code change labels Oct 18, 2021
mdelez
mdelez requested changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big thing but it should be resolved in this PR. In the new resource instance form, the checkbox is not aligned with the property label:
Screen Shot 2021-10-19 at 15 11 49

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Oct 19, 2021 •
edited

It's not a big thing but it should be resolved in this PR. In the new resource instance form, the checkbox is not aligned with the property label:
Screen Shot 2021-10-19 at 15 11 49

@mdelez resolved in 87b3bad

This styling issue was not an easy one. It was already bad in the previous version but I've never saw it. I had to improvising a bit.
Screen Shot 2021-10-19 at 15 56 11

@mdelez
Copy link
Collaborator

mdelez commented Oct 19, 2021

It's not a big thing but it should be resolved in this PR. In the new resource instance form, the checkbox is not aligned with the property label:
Screen Shot 2021-10-19 at 15 11 49

@mdelez resolved in 87b3bad

This styling issue was not an easy one. It was already bad in the previous version but I've never saw it. I had to improvising a bit. Screen Shot 2021-10-19 at 15 56 11

I figured it wouldn't be the easiest thing to align but your improvisation looks good :)

@kilchenmann kilchenmann merged commit 7affa5e into main Oct 20, 2021
@kilchenmann kilchenmann deleted the wip/dev-98-boolean-checkbox branch October 20, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees

@kilchenmann kilchenmann

Labels
bug A bug fix enhancement New feature or request refactor Refactor or redesign styling Update style; no production code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @mdelez