Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable edit/delete action in deactivated projects (DEV-52) #550

Merged
merged 7 commits into from Oct 15, 2021

Conversation

kilchenmann
Copy link
Contributor

resolves DEV-52

@kilchenmann kilchenmann self-assigned this Oct 14, 2021
@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request refactor Refactor or redesign styling Update style; no production code change labels Oct 14, 2021
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edit/delete actions are hidden when a project is deactivated however if I reactivate the project, the edit and delete icons for the property values remain hidden. If I then add a new value, I see the edit and delete icons but only for the new value.

Before deactivating project:
Screen Shot 2021-10-14 at 16 18 52

After reactivating the project:
Screen Shot 2021-10-14 at 16 19 54

@kilchenmann
Copy link
Contributor Author

The edit/delete actions are hidden when a project is deactivated however if I reactivate the project, the edit and delete icons for the property values remain hidden. If I then add a new value, I see the edit and delete icons but only for the new value.

Thanks for figuring this out. I have to check what happens. I use the project status; maybe a chache issue.

@kilchenmann
Copy link
Contributor Author

@mdelez the issue should be resolved now (e9b1fb5)

Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now! Thanks :)

@kilchenmann kilchenmann merged commit d7bec78 into main Oct 15, 2021
@kilchenmann kilchenmann deleted the wip/dev-52-resource-disable-action-buttons branch October 15, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix enhancement New feature or request refactor Refactor or redesign styling Update style; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants