Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): improve the current error handler in DSP-APP (DSP-1911) #540

Merged
merged 5 commits into from Sep 22, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Sep 20, 2021

resolves DSP-1911

You can test it as follows:

  • Start the app with the test-server configuration
  • Open the following page: http://0.0.0.0:4200/search/fulltext/Stygimoloch
  • If you're logged-in, you should see the correct error message from JS-Lib instead the 503 error mentioned in DSP-1910

Screen Shot 2021-09-20 at 22 42 55

Or

  • Start the app with your local api stack environment
  • Turn off the API
  • You should see the 503 server error

@kilchenmann kilchenmann self-assigned this Sep 21, 2021
@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request refactor Refactor or redesign labels Sep 21, 2021
@kilchenmann kilchenmann changed the title chore(error): improve the current error handler in DSP-APP (DSP-1911) fix(error): improve the current error handler in DSP-APP (DSP-1911) Sep 21, 2021
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@kilchenmann kilchenmann merged commit 0eb621b into main Sep 22, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1911-improve-error-handler branch September 22, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix enhancement New feature or request refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants