Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fulltext-search): persist fulltext search term in input field (DSP-1674) #539

Merged

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Sep 20, 2021

resolves DSP-1674

… field on page refresh. If a gravsearch query is performed, the input field is cleared
@mdelez mdelez added the refactor Refactor or redesign label Sep 20, 2021
@mdelez mdelez self-assigned this Sep 20, 2021
@mdelez
Copy link
Collaborator Author

mdelez commented Sep 21, 2021

@kilchenmann you can see it in action by searching for a resource using the fulltext search and then refreshing the results page. If you then make an advanced or expert search, the input field will be cleared. Also if you make a fulltext search and then go to the homepage, the search term will remain in the input field and if you refresh the page, the search term will be cleared (this isn't new though)

@kilchenmann
Copy link
Contributor

kilchenmann commented Sep 21, 2021

@kilchenmann you can see it in action by searching for a resource using the fulltext search and then refreshing the results page. If you then make an advanced or expert search, the input field will be cleared. Also if you make a fulltext search and then go to the homepage, the search term will remain in the input field and if you refresh the page, the search term will be cleared (this isn't new though)

Yes, I saw it yesterday in your demonstration. Sounds perfect 👍

@mdelez mdelez merged commit 67a52a3 into main Sep 21, 2021
@mdelez mdelez deleted the wip/DSP-1674-fulltext-search-show-search-term-after-refresh branch September 21, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants