Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: openseadragon prod build fix (DSP-1779) #534

Merged
merged 9 commits into from Sep 17, 2021
Merged

refactor: openseadragon prod build fix (DSP-1779) #534

merged 9 commits into from Sep 17, 2021

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Sep 15, 2021

resolves DSP-1779

@mdelez mdelez added the refactor Refactor or redesign label Sep 15, 2021
@mdelez mdelez self-assigned this Sep 15, 2021
kilchenmann
kilchenmann approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@kilchenmann kilchenmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! LGTM. Let's try....

@EricSommerhalder
Copy link
Contributor

Looks good to me as well. I feel like we should document somewhere that we only support rectangular regions at the moment though. I'm not sure where.

@mdelez
Copy link
Collaborator Author

mdelez commented Sep 16, 2021

Looks good to me as well. I feel like we should document somewhere that we only support rectangular regions at the moment though. I'm not sure where.

Yeah, that's a good point. I'll check the docs and see if they can be updated.

@kilchenmann
Copy link
Contributor

Looks good to me as well. I feel like we should document somewhere that we only support rectangular regions at the moment though. I'm not sure where.

Yeah, that's a good point. I'll check the docs and see if they can be updated.

The whole part about "Working with resources" is not yet written (or only partial). Here's the (data) user guide which has the be improved completely.

@mdelez mdelez merged commit 0a34eaa into main Sep 17, 2021
@mdelez mdelez deleted the wip/DSP-1779-osd-prod-build-fix branch September 17, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilchenmann kilchenmann kilchenmann approved these changes

@EricSommerhalder EricSommerhalder EricSommerhalder approved these changes

Assignees

@mdelez mdelez

Labels
refactor Refactor or redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdelez @EricSommerhalder @kilchenmann