feat(resource): draw regions (DSP-1845) #524
Conversation
EricSommerhalder
changed the title
src/app/workspace/resource/representation/add-region-form/add-region-form.component.html
Outdated
Show resolved
Hide resolved
src/app/workspace/resource/representation/add-region-form/add-region-form.component.html
Outdated
Show resolved
Hide resolved
| <form [formGroup]="regionForm"> | ||
| <mat-form-field> | ||
| <mat-label>Comment</mat-label> | ||
| <input matInput formControlName="comment"> |
There was a problem hiding this comment.
Comment field should be a textarea. But I think the form style could also be done in a separate, style refactoring PR.
There was a problem hiding this comment.
I changed it to a textarea for now, but I agree that a style refactoring PR will be needed.
|
After creating a region, it does not update the resource viewer. Only after refreshing the page I got the region in the annotation tab. And for any reason, I don't know why, it does not display the "is region of" in the region properties. I've checked and it's not an issue of the create region function. This has to be resolved in another PR; in the same PR we should also fix the typo in the german label "is Region von".
|
| ngOnInit(): void { | ||
| this.regionForm = this._fb.group({ | ||
| color: ['#ff3333', [Validators.required, Validators.pattern(this.colorPattern)]], | ||
| comment: [null, Validators.required], |
There was a problem hiding this comment.
is a comment actually required to submit the region?
There was a problem hiding this comment.
Yes, otherwise the api is not happy. Not sure why though.
| @@ -91,12 +114,14 @@ export class StillImageComponent implements OnChanges, OnDestroy { | |||
|
|
|||
| @Output() regionClicked = new EventEmitter<string>(); | |||
|
|
|||
| private _regionDrawMode: Boolean = false; // stores whether viewer is currently drawing a region | |||
| private _regionDragInfo; // stores the information of the first click for drawing a region | |||
| private _mouseTracker; // stores the MouseTracker that allows drawing regions | |||
There was a problem hiding this comment.
is this used anywhere? My IDE says it's unused so it can probably be removed
There was a problem hiding this comment.
At some point this got the whole thing running, but apparently it is not needed anymore. I have removed it.
+1 this should be handled in this PR. I've also noticed that editing the color of the region afterwards does not change the actual color of the region, even after refreshing but this can be handled in a different PR. |
resolves DSP-1845