Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(action): migrate action module (DSP-1852) #509

Merged
merged 11 commits into from Aug 19, 2021
Merged

refactor(action): migrate action module (DSP-1852) #509

merged 11 commits into from Aug 19, 2021

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Aug 17, 2021

resolves DSP-1852

@mdelez
refactor(action): migrates:
645398b 
- _viewer.scss
- statusMsg.ts
- confirmation-dialog comp
- confirmation-message comp
- login-form comp
- notification service
- sorting service
@mdelez mdelez added the refactor Refactor or redesign label Aug 17, 2021
@mdelez mdelez self-assigned this Aug 17, 2021
@mdelez mdelez requested a review from subotic August 18, 2021 10:38
@mdelez
Copy link
Collaborator Author

mdelez commented Aug 18, 2021

@subotic it's a ton of code but it's all code that we already know works. This PR is a simple migration of the code from the ui-lib, it does not update the imports within dsp-app to use this migrated code. That will happen in a future PR since I will basically touch every file.

@mdelez mdelez merged commit 725c45e into main Aug 19, 2021
@mdelez mdelez deleted the wip/DSP-1852-migrate-action-module branch August 19, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees

@mdelez mdelez

Labels
refactor Refactor or redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdelez @subotic