Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ontology): delete property from resource class (DSP-1854 / DEV-28) #499

Merged
merged 10 commits into from Oct 19, 2021
Merged

feat(ontology): delete property from resource class (DSP-1854 / DEV-28) #499

merged 10 commits into from Oct 19, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Aug 10, 2021 •
edited

resolves DEV-28 (resp. original task DSP-1854)

should work with latest version of DSP-API (v15.0.2).

@kilchenmann kilchenmann self-assigned this Aug 10, 2021
@kilchenmann kilchenmann marked this pull request as draft August 10, 2021 15:01
@kilchenmann
Copy link
Contributor Author

This PR needs a new version of DSP-API (PR #1869) and DSP-JS (PR #365)

@kilchenmann
Copy link
Contributor Author

This PR needs a new version of DSP-API (PR #1919)

@kilchenmann kilchenmann marked this pull request as ready for review October 19, 2021 11:28
@kilchenmann kilchenmann changed the title feat(ontology): delete property from resource class (DSP-1854) feat(ontology): delete property from resource class (DSP-1854 / DEV-28) Oct 19, 2021
@kilchenmann kilchenmann added the enhancement New feature or request label Oct 19, 2021
@kilchenmann kilchenmann removed the request for review from mdelez October 19, 2021 11:41
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Oct 19, 2021 •
edited

@mdelez This PR is not yet ready for the review... → now it's resolved and ready for a review

mdelez
mdelez approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kilchenmann
Copy link
Contributor Author

Looks good!

Thanks

@kilchenmann kilchenmann merged commit 436c270 into main Oct 19, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1854-delete-cardinality branch October 19, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees

@kilchenmann kilchenmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @mdelez