chore: improve error handler and fix search results issue (DSP-1826 / DSP-1831) #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was already written in DSP-UI. No need here to rewrite
kilchenmann
added
enhancement
kilchenmann
changed the title
mdelez
reviewed
Aug 2, 2021
| @@ -29,11 +28,9 @@ export class ResultsComponent { | |||
| searchMode: 'fulltext' | 'gravsearch'; | |||
|
|
|||
| // progress status | |||
| loading = true; | |||
| loading = false; | |||
There was a problem hiding this comment.
is this still needed? I don't think this variable is used anywhere now.
There was a problem hiding this comment.
wow, well seen 👍 no it's not needed anymore.
Removed in ed38403
mdelez
approved these changes
Aug 2, 2021
kilchenmann
deleted the
wip/dsp-1831-error-handler-and-fix-search-results
branch
|
Oh no, the title was wrong. This PR will not shown in the release notes |
kilchenmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1831
resolves DSP-1826