Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): add comparison view (DSP-1796) #490

Merged
merged 15 commits into from Jul 26, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jul 22, 2021

resolves DSP-1796

Just finished what @waychal has started.

DSP-UI PR #319 is required.

@kilchenmann kilchenmann self-assigned this Jul 22, 2021
@kilchenmann kilchenmann requested review from mdelez and Vijeinath and removed request for Vijeinath and mdelez July 22, 2021 14:20
@kilchenmann kilchenmann added dependencies Pull requests that update a dependency file enhancement New feature or request labels Jul 22, 2021
@mdelez
Copy link
Collaborator

mdelez commented Jul 26, 2021

@kilchenmann should I review this?

@kilchenmann
Copy link
Contributor Author

@kilchenmann should I review this?

@mdelez not yet. It needs some refactoring in dsp-ui first. I'll finish the PR in ui-lib today

@kilchenmann kilchenmann marked this pull request as draft July 26, 2021 11:49
@kilchenmann kilchenmann marked this pull request as ready for review July 26, 2021 12:59
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@kilchenmann kilchenmann merged commit 731ea04 into main Jul 26, 2021
@kilchenmann kilchenmann deleted the wip/DSP-1796-update-resource-viewer-for-comparison branch July 26, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants