feat(resource): add document viewer with download (DSP-1791) #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same view as for documents
kilchenmann
added
dependencies
|
This is how the still image viewer looks like: And here's the new document viewer: It's a first iteration and the viewer can still be improved with a lot of features. But for the moment this should be enough. |
…ch-swiss/dsp-app into wip/dsp-1791-document-viewer
waychal
reviewed
Jul 16, 2021
There was a problem hiding this comment.
For me open file in new tab button is not working but it is expected as I am using the test server for dsp-api. Other than that everything looks fine to me.
I will let @mdelez to approve the PR as he could also test the open file in new tab functionality.
mdelez
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1791
In this PR I actually wanted to integrate a simple download button for pdf file representations. But the main work was to generalise how we handle the different representation types. Previous everything was prepared for still images only. This is why I had to create a general
FileRepresentationtype. Additional I integrated a simple angular pdf viewer (ng2-pdf-viewer) and styled it the same way as we already did for the opeansedragon viewer for still images. I just had to adjust the still image viewer resp. I had to move the style to our main styling files to use the same setup for the new document viewer.