New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resource): upload pdf document (DSP-1776) #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am running DSP-APP locally using test server configuration. When I upload file, I do not see it once I save the changes. I have attached recording below. Also When I add resource label including -
(e.g. file-test
, it disables next
button and gives me wrong error in red text below. If I remove -
, it works fine.
Screen.Recording.2021-07-08.at.12.33.49.mov
Thanks @waychal for your comment. There are two things: The resource instance form has a bug in the label: it does not allow to use special characters. For me it's not understandable, why the label is restricted this way. But it's another topic and has to be resolved in another task. This task is only the implementation of an upload form for documents and that leads me to the second point: The viewer for a document is not implemented yet and will be handled in a separate task. |
Ok. But then in this case, how can I test the functionality? How can I know that the file is actually uploaded? I would like to get at least some alert or console message saying that if it is successful or there is an error. |
I know this is a problem, but the upload is needed to start with the document viewer. You can have a look in the |
Ok. I do not have dsp-api running locally because of new MacBook processor. So I can not test it. |
Sure. Thank you @waychal . I'm pretty sure that @mdelez will also have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upload works well! However I've noticed that you can save the file without providing a title, is this intended?
Also it would be nice to have title label fit nicely. Does it look okay on your end @kilchenmann?
The |
resolves DSP-1776