Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ontology): change gui element for text value properties (DSP-1624) #478

Merged
merged 5 commits into from Jul 5, 2021
Merged

feat(ontology): change gui element for text value properties (DSP-1624) #478

merged 5 commits into from Jul 5, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jul 2, 2021 •
edited

resolves DSP-1624

and

  • disable property form when adding existing property to resource class
  • disable period property because there's no difference to a single date property (as discussed with @gautschr)

incl. some bug fixes:

  • cardinality "multiple" is not allowed in boolean values → disabled form element in this case
  • display correct icon in list of properties (it was wrong in case of decimal value property)

@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request refactor Refactor or redesign labels Jul 2, 2021
@kilchenmann kilchenmann assigned kilchenmann and unassigned subotic, waychal and mdelez Jul 3, 2021
waychal
waychal approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@waychal waychal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine after testing the functionality using test server.

@kilchenmann kilchenmann merged commit 6af1f7e into main Jul 5, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1624-change-gui-element branch July 5, 2021 12:11
@kilchenmann kilchenmann changed the title feat(ontology): change gui element for text value properties feat(ontology): change gui element for text value properties (DSP-1624) Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

@waychal waychal waychal approved these changes

@mdelez mdelez Awaiting requested review from mdelez

Assignees

@kilchenmann kilchenmann

Labels
bug A bug fix enhancement New feature or request refactor Refactor or redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kilchenmann @subotic @waychal @mdelez