New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ontology): display description for default and existing props (DSP-1154) #475
Conversation
The description from the default properties will be displayed as tooltipp: @mdelez could you check the english sentences? Thanks |
I suggest for "Text": A question concerning Date/Time: The inclusion of the new GUI element which allows for a proper display of dates with lower precision than one day - is this another PR? |
I will update as suggested. → done in 6fb9746
The new gui element for dates should already be implemented. So yes, how should the description look like? |
src/app/project/ontology/property-form/property-form.component.spec.ts
Outdated
Show resolved
Hide resolved
@@ -218,18 +235,11 @@ export class DefaultProperties { | |||
{ | |||
icon: 'palette', | |||
label: 'Color', | |||
description: 'A simple color value', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably clarify that this is a hexadecimal value. Ex: "A hexadecimal color value"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if everyone understands the term "hexadecimal". Apart from that, in the GUI we have the color picker only and the hexadecimal value itself is not displayed anymore (s. DSP-1667)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair :)
} | ||
// { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this code still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we have to reactivate it one day!?
We need a kind of dd/mm/yyyy BCE/CE icon and for the short description I suggest "dd/mm/yyyy format; for historical dates" |
resolves DSP-1154