New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cookie-policy): reactivate the cookie policy banner (DSP-1727) #461
Conversation
The "history back" button doesn't work anymore. Will fix it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there needs to be a "Reject" button as well, no? There is currently no way to dismiss the banner besides clicking the "Accept" button.
src/app/app.component.html
Outdated
<!-- cookie information banner --> | ||
<div class="cookie-banner" *ngIf="showCookieBanner"> | ||
<p class="note"> | ||
This web-application uses cookies to provide you with great user experience. By using the application you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with a greater user experience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewritten in fd2ecf2
But what should happen, when the user click on "reject"? Redirect the user to a google page? Because in this case s/he can't use the app. |
The website should still be useable even if the user rejected all non-essential cookies. We can still use cookie that are essential to the website operating. The user just needs to be allowed the reject any cookie that may have identifying data. https://gdpr.eu/cookies/#:~:text=To%20comply%20with%20the%20regulations,cookies%20except%20strictly%20necessary%20cookies.&text=Allow%20users%20to%20access%20your,the%20use%20of%20certain%20cookies |
Yes I know and you're right, but in DSP-APP we have only essential cookies (the one for the login). When the user reject them s/he can't use the app. This is why I wrote: "If you want to use the app, you have to accept the cookie policy". |
That's fair. So then at that point I don't think we even need a cookies banner. You could also just add a "Reject non-essential cookies" button that does nothing but dismiss the banner since we don't have any non-essential cookies. |
As @subotic said yesterday, I should reactivate the banner. So that's what I did. |
Thank you @mdelez |
resolves DSP-1727