New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(resource): improve list of properties in resource viewer (DSP-1663) #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the functionality and it works fine.
src/app/app.module.ts
Outdated
import { StillImageComponent } from './workspace/resource/representation/still-image/still-image.component'; | ||
import { PropertiesComponent } from './workspace/resource/properties/properties.component'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please sort the imports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 17058ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works perfectly - thank you!
resolves DSP-1663
In this PR I combined/copied the two components
ResourceToolbarComponent
andResourcePropertiesComponent
into one new component. It was an old implementation from DSP-UI but this use case is no longer needed. With the combination I tried also to simplify the html template and the component parameters. The toggle button to show or hide empty properties works better because it's directly part of the newPropertiesComponent
. Best way to test the button:Additional I resolved the issue mentioned in the third item of #445 (review)