Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(project): resolve regex term (DSP-1654) #444

Merged
merged 3 commits into from May 21, 2021
Merged

chore(project): resolve regex term (DSP-1654) #444

merged 3 commits into from May 21, 2021

Conversation

kilchenmann
Copy link
Contributor

resolves DSP-1654

@kilchenmann kilchenmann self-assigned this May 21, 2021
@kilchenmann kilchenmann added the chore Maintenance and build tasks label May 21, 2021
@kilchenmann
Copy link
Contributor Author

It seems to be fixed: https://github.com/dasch-swiss/dsp-app/pull/444/checks?check_run_id=2637192631

@mdelez
Copy link
Collaborator

mdelez commented May 21, 2021

@kilchenmann this change doesn't affect how the regex behaves right? It just removes something unnecessary?

@kilchenmann
Copy link
Contributor Author

@kilchenmann this change doesn't affect how the regex behaves right? It just removes something unnecessary?

Yes

@kilchenmann kilchenmann merged commit 739beba into main May 21, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1654-code-scanning-issues branch May 21, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

@waychal waychal Awaiting requested review from waychal

Assignees

@kilchenmann kilchenmann

Labels
chore Maintenance and build tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @mdelez