chore(migrate to angular10): changes (DSP-1415) #412
Conversation
waychal
changed the title
| "jdnconvertiblecalendar": "^0.0.5", | ||
| "jdnconvertiblecalendardateadapter": "^0.0.13", | ||
| "jdnconvertiblecalendar": "^0.0.6", | ||
| "jdnconvertiblecalendardateadapter": "^0.0.15", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
sorry, 0.0.15 is fine
waychal
force-pushed
the
wip/DSP-1415-migrate-to-angular10
branch
from
3e206c2
to
30f4899
Compare
There was a problem hiding this comment.
I spotted a few warnings about modules built with commonJS:
WARNING in dsp-app/node_modules/@dasch-swiss/dsp-js/test/data/api/admin/mock-users.js depends on 'json2typescript'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'ngraph.graph'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'ngraph.forcelayout'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
WARNING in dsp-app/node_modules/three-forcegraph/dist/three-forcegraph.module.js depends on 'tinycolor2'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
Maybe for some of these packages there is a newer version that could be used instead?
I will check it. |
otherwise these warnings can be ignored, see https://stackoverflow.com/questions/62589229/angular-10-upgrade-fix-commonjs-or-amd-dependencies-can-cause-optimization-bai |
|
@tobiasschweizer I have removed the warnings for CommonJS or AMD dependencies. Can you please review the PR again? |
resolves DSP-1415