refactor(project landing page): update metadata typings (DSP-1393) #407
Conversation
mpro7
changed the title
src/app/app.module.ts
Outdated
| PropertyInfoComponent, | ||
| UrlTemplateComponent |
There was a problem hiding this comment.
Let's have the declarations sorted.
| <div *ngIf="templateType == 'string'"> | ||
| <p *ngFor="let str of urls" class="remove-top-margin"> {{ str }} </p> | ||
| </div> | ||
| <div *ngIf="templateType == 'IUrl'"> |
There was a problem hiding this comment.
Use strict equality operator ===.
| @Input() displayLabel ?: boolean = false; | ||
|
|
||
| @Input() isPerson ?: boolean = false; |
There was a problem hiding this comment.
You can remove typings here because of initiation with the primitive values. Also safe operator ? doesn't require space after property name.
|
@waychal I'm sorry, I was on the wrong PR and updated from main. |
Could you revert that please? It broke the build. |
|
@kilchenmann No problem. I will check it. I normally rebase the main branch but merge is also fine. |
I'll fix it, if it's okay. Just a missing comma in |
resolves DSP-1393