Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(list-editor): insert a child node at a specific position (DSP-1301) #395

Merged
merged 9 commits into from Feb 26, 2021
Merged

feat(list-editor): insert a child node at a specific position (DSP-1301) #395

merged 9 commits into from Feb 26, 2021

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Feb 24, 2021

resolves DSP-1301

@mdelez mdelez added the enhancement New feature or request label Feb 24, 2021
@mdelez mdelez self-assigned this Feb 24, 2021
@mdelez
Copy link
Collaborator Author

mdelez commented Feb 24, 2021

tests won't run on GithubCi until a version of DSP-JS is released with this change dasch-swiss/dsp-js-lib#322

@kilchenmann
Copy link
Contributor

tests won't run on GithubCi until a version of DSP-JS is released with this change dasch-swiss/dsp-js-lib#322

I can do a release of js-lib. The problem is the following: PR #322 is marked as refactor which is ignored by release-please (s. contribution documentation --> "The first three items on this list (fix, feat and type with !) are taken into account for the release notes and have an effect on the version number.") and this is why the github actions didn't create a release PR. We could create a new release manually or waiting for the next merged PR.

@kilchenmann
Copy link
Contributor

@mdelez p.s. I created a user story about the refactor-topic in PRs: DSP-1378

@mdelez
Copy link
Collaborator Author

mdelez commented Feb 25, 2021

tests won't run on GithubCi until a version of DSP-JS is released with this change dasch-swiss/dsp-js-lib#322

I can do a release of js-lib. The problem is the following: PR #322 is marked as refactor which is ignored by release-please (s. contribution documentation --> "The first three items on this list (fix, feat and type with !) are taken into account for the release notes and have an effect on the version number.") and this is why the github actions didn't create a release PR. We could create a new release manually or waiting for the next merged PR.

oh cool, thanks for the info! It's not urgent as I can use yalc for the time being until another PR is merged :)

@mdelez
Copy link
Collaborator Author

mdelez commented Feb 25, 2021

Also waiting for this change from DSP-JS dasch-swiss/dsp-js-lib#324

kilchenmann
kilchenmann reviewed Feb 26, 2021
View reviewed changes
src/app/project/list/list-item-form/edit-list-item/edit-list-item.component.ts Outdated
@@ -1,5 +1,5 @@
import { Component, EventEmitter, Inject, Input, OnInit, Output } from '@angular/core';
import { ApiResponseData, ApiResponseError, ChildNodeInfoResponse, KnoraApiConnection, List, ListNodeInfo, ListNodeInfoResponse, StringLiteral, UpdateChildNodeRequest } from '@dasch-swiss/dsp-js';
import { ApiResponseData, ApiResponseError, ChildNodeInfoResponse, CreateChildNodeRequest, KnoraApiConnection, List, ListNodeInfo, ListNodeInfoResponse, StringLiteral, UpdateChildNodeRequest } from '@dasch-swiss/dsp-js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This long line should be aligned

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 0b490f3

@mdelez mdelez merged commit 5107200 into main Feb 26, 2021
@mdelez mdelez deleted the wip/DSP-1301-insert-child-node-at-position branch February 26, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilchenmann kilchenmann kilchenmann approved these changes

@flavens flavens flavens approved these changes

Assignees

@mdelez mdelez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdelez @kilchenmann @flavens