Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint): migrate tslint to eslint (DSP-1372) #394

Merged
merged 62 commits into from Mar 4, 2021
Merged

feat(eslint): migrate tslint to eslint (DSP-1372) #394

merged 62 commits into from Mar 4, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Feb 24, 2021 •
edited

resolves DSP-1372

The most important file that has to be reviewed in this PR is the .eslintrc.js (eslint config file).

@kilchenmann
test(eslint): migrate from tslint to eslint
ec9fe3d
@kilchenmann
chore(eslint): two commands to run lint tool
c32cf6a
@kilchenmann
refactor(eslint): automatically fixed errors by esLint rules
86df038
@kilchenmann
refactor(user): refactor code by following ESLint rules
3857762
@kilchenmann
refactor(user): refactor code by following ESLint rules
95d2aa1
@kilchenmann
refactor(main): refactor code by following ESLint rules
40fd28c
@kilchenmann
refactor(user): refactor code by following ESLint rules
30a2d93
@kilchenmann
refactor(comments): undo ugly tODO comment but still following esLint…
2a101df 
… rules
@kilchenmann
refactor(ontology): refactor code by following ESLint rules
55ff53b
@kilchenmann
refactor(ontology): refactor code by following ESLint rules
37bc628
@kilchenmann
refactor(ontology-visualizer): refactor code by following ESLint rules
9287c56
@kilchenmann
refactor(ontology): refactor code by following ESLint rules
3fd6367
@kilchenmann
refactor(permission): refactor code by following ESLint rules
de4b6cc
@kilchenmann
refactor(system): refactor code by following ESLint rules
a2bf818
@kilchenmann
refactor(user): refactor code by following ESLint rules
628ef8e
@kilchenmann
refactor(main): refactor code by following ESLint rules
896e39d
@kilchenmann
refactor(project): refactor code by following ESLint rules
1256d51
@kilchenmann
refactor(system): refactor code by following ESLint rules
704eebb
@kilchenmann
refactor(project): refactor code by following ESLint rules
1fb5245
@kilchenmann
refactor(user): refactor code by following ESLint rules
4be1875
@kilchenmann
test(ontology): bug fix in res class form service
1247bf0
@kilchenmann
chore(gh-ci): use new eslint
c9455ab
@kilchenmann
docs(contribution): update linter section with new eslint config
313caf3
@kilchenmann
refactor(tests): delete tslint
d46b810
@kilchenmann
refactor(ontology): refactor code by following ESLint rules
7f5b1b3
@kilchenmann kilchenmann self-assigned this Feb 24, 2021
@kilchenmann kilchenmann added chore Maintenance and build tasks dependencies Pull requests that update a dependency file refactor Refactor or redesign labels Feb 24, 2021
mpro7
mpro7 reviewed Mar 2, 2021
View reviewed changes
.eslintrc.js Show resolved Hide resolved
flavens
flavens reviewed Mar 2, 2021
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
@kilchenmann kilchenmann requested a review from flavens March 2, 2021 14:28
@kilchenmann kilchenmann requested a review from mpro7 March 3, 2021 15:49
@kilchenmann
Copy link
Contributor Author

For the reviewers: I just added new rules about spaces in objects which is defined here:
https://docs.google.com/document/d/1SIVMxoV0N8xYqhVk_0hhuqSuUF47D1YYrDESqdmipfM/edit#heading=h.awf6ef8h98ze

@kilchenmann kilchenmann merged commit 6ffc3b6 into main Mar 4, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1372-migrate-tslint-to-eslint branch March 4, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavens flavens flavens approved these changes

@mdelez mdelez mdelez approved these changes

@SepidehAlassi SepidehAlassi Awaiting requested review from SepidehAlassi

@waychal waychal Awaiting requested review from waychal

@tobiasschweizer tobiasschweizer Awaiting requested review from tobiasschweizer

@mpro7 mpro7 Awaiting requested review from mpro7

Assignees

@kilchenmann kilchenmann

Labels
chore Maintenance and build tasks dependencies Pull requests that update a dependency file documentation Add or update doc files refactor Refactor or redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kilchenmann @mpro7 @flavens @mdelez