New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ontology): separate list of ontology properties (DSP-1364) #391
Conversation
.ontology-editor-canvas { | ||
min-height: calc(100vh - #{$sub-header-height} - #{$header-height} - #{$tab-bar-margin} - 100px); | ||
// background: $primary_200; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when there are unused css classes, we should clean them up or add a comment (remark valid for all the scss files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the css classes are not defined in the scss file, that's true. But they are needed for the tests.
Or are you talking about the commented css property here? I can clean them up...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in ac7c3cf
Yes I know. I'm using the number from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would stress that we need to have some unit tests for the ontology component but I don't think this is the PR for that so I'll approve this one :)
I'm working on it 😉 |
resolves DSP-1364
This is a first version of a separate list of properties. In another task we will add a filter and sort button.