Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology): bug fix in list property (DSP-1368) #390

Merged
merged 5 commits into from Feb 23, 2021

Conversation

kilchenmann
Copy link
Contributor

resolves DSP-1368

@kilchenmann kilchenmann self-assigned this Feb 22, 2021
@kilchenmann kilchenmann added the bug A bug fix label Feb 22, 2021
Copy link
Contributor

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the fdescribe (see my comment) - so let's see if all the tests still pass!!


}

fdescribe('PropertyInfoComponent', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you left a fdescribe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Oops, I forgot to remove it. → done in 21eea72

@kilchenmann kilchenmann merged commit 2fb448e into main Feb 23, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1368-property-list-label branch February 23, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants