feat(ontology): refactor list of properties in resource class (DSP-1360) #389

kilchenmann · 2021-02-17T16:50:36Z

resolves DSP-1360 (bug fix by returning resource class and properties in all languages)

incl. refactoring of cache and ontology editor in general.

The ontology editor lists the resource classes with new list of corresponding properties; the design contains:

gui order
icon = property type (subclass and gui element); has a tooltip with more information
label = property label with property comment in tooltip;
- in case of a link property it shows corresponding resource class
- in case of a list property it shows corresponding list as a link
cardinality = checkbox icons for "can have multiple values" and "value is required"

flavens

There are some index, e.g. 0) 1), that are doubled or tripled, or even missing, e.g. 0) -> 2)
Is it normal behaviour to be able to click on the referred list but not on the linked resource?
Maybe only on my local app: For the BEOL ontologies, I have an error message in the console.log: "Cannot read property 'label' of undefined" - property-info.component.ts:95

kilchenmann · 2021-02-18T10:26:02Z

There are some index, e.g. 0) 1), that are doubled or tripled, or even missing, e.g. 0) -> 2)

The Gui order is defined in the ontology; it's part of the res class cardinality. In case of missing or doubled numbers it's a mistake in the ontology. The test data are not well done.

Is it normal behaviour to be able to click on the referred list but not on the linked resource?

Yes. At the moment we do not have a native route for the linked resource class. I was thinking to highlight the linked class somehow. But this will take more time.

Maybe only on my local app: For the BEOL ontologies, I have an error message in the console.log: "Cannot read property 'label' of undefined" - property-info.component.ts:95

I will check this...

mdelez · 2021-02-18T10:36:43Z

Maybe only on my local app: For the BEOL ontologies, I have an error message in the console.log: "Cannot read property 'label' of undefined" - property-info.component.ts:95

I have the same console error. The BEOL ontology also has a lot of empty resource classes at the bottom for some reason. Maybe that's the issue @kilchenmann?

EDIT: Actually, the Biblio ontology has 36 of these console errors and doesn't contain any empty resource classes,

kilchenmann · 2021-02-18T10:42:09Z

Yes there's something weird with the ontology test-data in some projects. I will spend some time to do some investigations. Maybe someone of you can help me with that?

kilchenmann · 2021-02-18T10:47:10Z

I already found something: the empty resource classes doesn't have a label. They are all of type "Standoff"-something. Will try to fix it; standoff doesn't have to be displayed

mdelez · 2021-02-18T10:46:11Z

src/app/project/ontology/property-info/property-info.component.spec.ts

+    it('should create', () => {
+        expect(testHostComponent).toBeTruthy();
+    });
+});


I would add a test here to ensure the component is receiving the correct data for propDef, propCard, and projectcode via the @Inputs

@kilchenmann please add these assertions and then I will approve :)

Will add it this evening.

done in 8cf574e

mdelez · 2021-02-18T10:46:14Z

src/app/project/ontology/property-info/property-info.component.ts

+
+    @Input() propCard: IHasProperty;
+
+    @Input() projectcode: string;


projectcode -> projectCode

it's the same as in other components. To be consistent, I have to change it everywhere. But I can do it...

I've noticed it elsewhere as well. Maybe leave it for now and we can open a small PR to rename them everywhere all at once.

kilchenmann · 2021-02-18T10:59:42Z

I have the same console error. The BEOL ontology also has a lot of empty resource classes at the bottom for some reason.

I found the problem. The linked resource is defined in another ontology. The ontology editor is not yet prepared for this case. It will make the things more complex 🙈 ... but fine, I'll fix it.

kilchenmann · 2021-02-18T21:22:42Z

It seems to be fixed now. I had to integrate new cache for currentProjectOntologies. Now we have the class information from other ontologies than the current one if in case a link property is connected with a class from another ontology.

subotic · 2021-02-18T23:13:29Z

great, so as soon as you merge this, please make a release and deploy it to test and staging. thanks.

kilchenmann and others added 14 commits February 16, 2021 10:35

feat(ontology): own component for list of properties in res class

87bd979

Merge branch 'main' into wip/dsp-1210-edit-res-property

5baf95c

test(ontology): update test for property info component

96a6c64

feat(ontology): better list of props in class

268115d

Merge branch 'main' into wip/dsp-1210-edit-res-property

b0f8ebc

chore(cache): better error message in cache

b86ccdf

chore(ontology): better cache handling to use in child component

00be1f2

feat(ontology): new list of properties in res class

a0684e1

style(ontology): refactor res class viewer

d177214

chore(ontology): update property info component

bf7490b

refactor(ontology): clean up code

48e2323

refactor(ontology): clean up code

e49503a

refactor(ontology): clean up code

700b152

Merge branch 'main' into wip/dsp-1360-list-of-properties-in-res-class

84e9bca

kilchenmann self-assigned this Feb 17, 2021

kilchenmann added bug A bug fix enhancement New feature or request labels Feb 17, 2021

kilchenmann added 2 commits February 17, 2021 18:02

test(ontology): bug fix in tests

7125bee

chore(deps): update package-lock.json

2f91151

kilchenmann requested review from subotic, flavens and mdelez February 17, 2021 17:20

kilchenmann added 2 commits February 18, 2021 08:02

fix(ontology): avoid null:null in prop type tooltip

b11b155

chore(ontology): add missing space

50b6eaf

flavens reviewed Feb 18, 2021

View reviewed changes

mdelez requested changes Feb 18, 2021

View reviewed changes

kilchenmann added 6 commits February 18, 2021 15:06

fix(ontology): display prop even without gui order

9edc72d

style(ontology): fix design issue in res class form

3956cdc

refactor(ontology): clean up code

6a5a3e4

refactor(ontology): clean up code

b6ef4bb

feat(ontology): support all project ontologies in list of properties

e006deb

chore(ontology): delete console.logs

791b4b6

kilchenmann requested review from mdelez and flavens February 18, 2021 21:20

kilchenmann added 4 commits February 20, 2021 13:50

refactor(ontology): fix typo in comments

d64b745

fix(ontology): fix cache issues in main ontology view

0752f1f

refactor(ontology): delete console.logs

2f2b27d

test(ontology): add more property info tests

8cf574e

mdelez approved these changes Feb 22, 2021

View reviewed changes

Merge branch 'main' into wip/dsp-1360-list-of-properties-in-res-class

84e8d1c

kilchenmann changed the title ~~fix(ontology): refactor list of properties in resource class (DSP-1360)~~ feat(ontology): refactor list of properties in resource class (DSP-1360) Feb 22, 2021

kilchenmann merged commit aa565b3 into main Feb 22, 2021

kilchenmann deleted the wip/dsp-1360-list-of-properties-in-res-class branch February 22, 2021 08:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ontology): refactor list of properties in resource class (DSP-1360) #389

feat(ontology): refactor list of properties in resource class (DSP-1360) #389

kilchenmann commented Feb 17, 2021 •

edited

flavens left a comment

kilchenmann commented Feb 18, 2021

mdelez commented Feb 18, 2021 •

edited

kilchenmann commented Feb 18, 2021

kilchenmann commented Feb 18, 2021 •

edited

mdelez Feb 18, 2021

mdelez Feb 19, 2021

kilchenmann Feb 19, 2021

kilchenmann Feb 20, 2021

mdelez Feb 18, 2021

kilchenmann Feb 18, 2021

mdelez Feb 18, 2021

kilchenmann commented Feb 18, 2021

kilchenmann commented Feb 18, 2021

subotic commented Feb 18, 2021


		@Input() propCard: IHasProperty;

		@Input() projectcode: string;

feat(ontology): refactor list of properties in resource class (DSP-1360) #389

feat(ontology): refactor list of properties in resource class (DSP-1360) #389

Conversation

kilchenmann commented Feb 17, 2021 • edited

flavens left a comment

Choose a reason for hiding this comment

kilchenmann commented Feb 18, 2021

mdelez commented Feb 18, 2021 • edited

kilchenmann commented Feb 18, 2021

kilchenmann commented Feb 18, 2021 • edited

mdelez Feb 18, 2021

Choose a reason for hiding this comment

mdelez Feb 19, 2021

Choose a reason for hiding this comment

kilchenmann Feb 19, 2021

Choose a reason for hiding this comment

kilchenmann Feb 20, 2021

Choose a reason for hiding this comment

mdelez Feb 18, 2021

Choose a reason for hiding this comment

kilchenmann Feb 18, 2021

Choose a reason for hiding this comment

mdelez Feb 18, 2021

Choose a reason for hiding this comment

kilchenmann commented Feb 18, 2021

kilchenmann commented Feb 18, 2021

subotic commented Feb 18, 2021

kilchenmann commented Feb 17, 2021 •

edited

mdelez commented Feb 18, 2021 •

edited

kilchenmann commented Feb 18, 2021 •

edited