feat(list-editor): reposition a child node amongst its siblings (DSP-1340) #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I discovered I was using quite an old version of npm which was creating conflicting package-lock.json files. Should be fixed now. |
|
@kilchenmann This PR adds these two buttons to the "action bubble" and the up and down arrows hide if the node cannot move in that direction. I did not implement it as drag and drop for version 1. Explained in more detail here. |
waychal
suggested changes
Feb 19, 2021
| </button> | ||
| <button mat-button | ||
| *ngIf="!lastPosition" | ||
| class="reposition down" |
There was a problem hiding this comment.
According to the conventions written here class should be at the end.
waychal
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1340