Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ontology): edit data model info (DSP-1208) #385

Merged
merged 12 commits into from Mar 18, 2021
Merged

feat(ontology): edit data model info (DSP-1208) #385

merged 12 commits into from Mar 18, 2021

Conversation

kilchenmann
Copy link
Contributor

resolves DSP-1208

@kilchenmann kilchenmann self-assigned this Feb 16, 2021
@kilchenmann kilchenmann marked this pull request as draft February 16, 2021 09:51
@kilchenmann kilchenmann added the enhancement New feature or request label Feb 16, 2021
@kilchenmann kilchenmann mentioned this pull request Mar 12, 2021
Merged
@kilchenmann kilchenmann marked this pull request as ready for review March 17, 2021 16:22
flavens
flavens reviewed Mar 18, 2021
View reviewed changes
Copy link
Contributor

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thing, you can edit the tooltip when you mouse over the Edit button:

Screenshot 2021-03-18 at 15 33 10

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Mar 18, 2021 •
edited

LGTM, just one thing, you can edit the tooltip when you mouse over the Edit button:

oh...sure. Will update asap 🙈 --> Done in 16fc54a

@flavens flavens self-requested a review March 18, 2021 15:35
@kilchenmann kilchenmann merged commit 86a5fb8 into main Mar 18, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1208-edit-data-model-info branch March 18, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavens flavens flavens approved these changes

@mdelez mdelez Awaiting requested review from mdelez

Assignees

@kilchenmann kilchenmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @flavens