Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): default language for property label #382

Merged
merged 8 commits into from Feb 17, 2021

Conversation

kilchenmann
Copy link
Contributor

resolves DSP-1346

In this PR I implemented a select form element to select one default language for the property label.

@kilchenmann kilchenmann self-assigned this Feb 15, 2021
@kilchenmann kilchenmann added bug A bug fix enhancement New feature or request labels Feb 15, 2021
@kilchenmann kilchenmann marked this pull request as draft February 15, 2021 17:05
@kilchenmann kilchenmann marked this pull request as ready for review February 16, 2021 15:00
Copy link
Contributor

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my screen, the field label is cropped.. It may be too long as well.

Screenshot 2021-02-16 at 16 48 04

And when I update the corresponding props in English first and then I open again the edit form and change the language to Deutsch. How do I know in which language is my props, is there a mix? If a user wants to enter the props in 2 languages, can s.he do that? If yes, it is not clear to me.

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Feb 16, 2021

On my screen, the field label is cropped.. It may be too long as well.

What do you mean "it's cropped"?@flavens I figured it out, which label you meant 🙈 It's the placeholder... yes it's too long. Still looking for a better term, because I don't want to make the selection wider.

And when I update the corresponding props in English first and then I open again the edit form and change the language to Deutsch. How do I know in which language is my props, is there a mix? If a user wants to enter the props in 2 languages, can s.he do that? If yes, it is not clear to me.

Yes you're right it's not clear. It's a first try and has to be well documented, but it has to be improved too. In this first version of ontology editor you have to select one language for all properties. You can add more labels in other languages later in the edit property part (this is another branch I'm working on). But for now this is a fast solution to create properties with a language.

p.s. maybe we have to disable the language selector when editing the cardinalities!? → done in 5adbc10

@kilchenmann
Copy link
Contributor Author

On my screen, the field label is cropped.. It may be too long as well.

Shortened the placeholder in e5b5a94

Copy link
Contributor

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language selector issue should be improved quite soon because even disabled, I am not that a user will understand the situation...

@kilchenmann
Copy link
Contributor Author

The language selector issue should be improved quite soon because even disabled, I am not that a user will understand the situation...

I totally agree and I'm open for better solutions!

Thanks for approving 🎉

@kilchenmann kilchenmann merged commit 97230d1 into main Feb 17, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1346-default-language-for-properties branch February 17, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants