feat(ontology): update cardinality in resource class (DSP-1266) #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavens
reviewed
Feb 10, 2021
| @@ -1,6 +1,7 @@ | |||
| <div *ngIf="projectAdmin" class="desktop-only"> | |||
|
|
|||
| <p class="note warning center">This is a first version of the ontology editor. Some features may not work as intended.</p> | |||
| <p class="note warning center">This is a first version of the ontology editor. Some features may not work as | |||
There was a problem hiding this comment.
should we stick to "data model" instead of "ontology editor"?
There was a problem hiding this comment.
done in 4df6c48
| @@ -164,8 +178,9 @@ export class PropertyFormComponent implements OnInit { | |||
| * @returns Filtered list of options | |||
| */ | |||
| filter(list: AutocompleteItem[], label: string) { | |||
| console.log(list) | |||
There was a problem hiding this comment.
this console.log must be removed
There was a problem hiding this comment.
done in d74a77d
| this.properties.setControl | ||
| resourceClass.properties.forEach(prop => { | ||
| this.properties[i] = new FormControl(prop); | ||
| // this.properties[i].setValue(prop); |
There was a problem hiding this comment.
should we keep these commented lines?
There was a problem hiding this comment.
done in de4ac1f
subotic
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1266
It works with new created ontologies. Most of the test ontologies doesn't have a
lastModificationDateand they can't be edited.Here are two screen records about "How to update cardinality":
update-res-class-card-interview.mp4
create-and-update-res-class-photo.mp4
The wording will be done in a separate task.