refactor(app+main)!: comment out the search and everything related to resources (DSP-1291) #371
Conversation
… search and res collections
| </dsp-search-panel> | ||
| <!-- advanced and expert search (in desktop and tablet version) --> | ||
| </dsp-search-panel> --> | ||
| <!-- to keep? > advanced and expert search (in desktop and tablet version) --> |
There was a problem hiding this comment.
"to keep?" --> good point. I think we can delete it. It could be done in a separate refactoring task
|
@kilchenmann about the 2 PRs, should we merge them into main or in a new branch, e.g. dsp-admin? |
This is the question. But how could we do a release and a build from this specific branch? |
|
@kilchenmann could you check the changes in the readme file? done in 52e90f2 |
README.md
Outdated
| @@ -1,18 +1,18 @@ | |||
| # DSP APP — Generic user interface of DaSCH Service Platform | |||
| # DSP-ADMIN — Admin user interface of DaSCH Service Platform | |||
There was a problem hiding this comment.
It could be confusing when the repo's name is dsp-app but the title is dsp-admin...
|
@flavens wouldn't it be better to mark this PR as breaking change? Because we have significantly reduced the functionality of the app. In this case we will get a new version (4.0.0) and we know, that this version is the dsp-admin version only. |
kilchenmann
changed the title
resolves DSP-1291