New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(project landing page): add copy to clipboard functionality (DSP-1248) #368
Conversation
…nd replace bracket notation with dot notation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good, but before you merge:
- Have a look on my late comments from last PR.
- DSP-1284 doesn't exists.
- Don't put space between PR title type and scope
feat():
instead offeat ():
. - Creating branch start with
wip/
prefix, sowip/dsp-xxx
instead of justdsp-xxx
.
I have updated this PR for your comments from another PR.
Thanks, I have corrected it in PR title and description.
Done.
Normally when I create PR they are no longer work in progress (wip). Hence I do not add |
Thanks! |
resolves DSP-1248
adds copy to clipboard functionality for
citation link
,persistent identifier
andlicense
using Angular CDK clipboard module.