feat(list editor): Adds support for editing lists (DSP-741) #365
Conversation
mdelez
force-pushed
the
wip/DSP-741-edit-list-item-attempt-2
branch
from
2f66840
to
ff312af
Compare
|
@flavens @kilchenmann new edit feature can be found in the app in the list editor of a project and by hovering over a list node :) |
|
oh, also make sure you're using DSP-API 13.1.1! |
| color="primary" | ||
| [disabled]="saveButtonDisabled" | ||
| (click)="updateChildNode()"> | ||
| Update |
There was a problem hiding this comment.
you used {{ 'appLabels.form.action.cancel' | translate }} line 30, should use the format {{ 'appLabels.form.action.update' | translate }} here as well?! It exists in the en.json file
There was a problem hiding this comment.
This was André's code that I moved around. I changed the text to use the translate pipe for 'update' in 2c88e7e.
| ); | ||
| } | ||
|
|
||
| buildForm(list: ListNodeInfo): void { |
There was a problem hiding this comment.
would it be possible to add some description for each method, and possibly for tricky code lines?
| @@ -86,51 +114,40 @@ export class ListItemFormComponent implements OnInit { | |||
| } | |||
| } | |||
|
|
|||
| submitData() { | |||
| createChildNode() { | |||
There was a problem hiding this comment.
I will be picky: would it be possible to add in this file as well some method description?
There was a problem hiding this comment.
I tried my best as I don't fully understand some of the methods either 😅 added in be62277
| @@ -54,7 +55,6 @@ export class ListItemComponent implements OnInit { | |||
| } | |||
| ); | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| showChildren(id: string): boolean { | |||
There was a problem hiding this comment.
I will be picky: would it be possible to add in this file as well some method description? even though it is not from you
resolves DSP-741