Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(select-resource-class): allow accented character (DSP-1241) #363

Merged
merged 2 commits into from Jan 20, 2021
Merged

feat(select-resource-class): allow accented character (DSP-1241) #363

merged 2 commits into from Jan 20, 2021

Conversation

flavens
Copy link
Contributor

@flavens flavens commented Jan 19, 2021

Resolves DSP-1241

@flavens flavens added the enhancement New feature or request label Jan 19, 2021
@flavens flavens self-assigned this Jan 19, 2021
@flavens flavens requested a review from mdelez January 19, 2021 14:55
mdelez
mdelez reviewed Jan 19, 2021
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to use ranges instead of hardcoded values here unless we only want support for german and french in which case you might also want to add ß. https://stackoverflow.com/a/26900132
https://en.wikipedia.org/wiki/List_of_Unicode_characters#Basic_Latin

@flavens flavens requested a review from mdelez January 19, 2021 17:33
mdelez
mdelez approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One thing to note is that this allows for a few math symbols (÷, ×). Not sure if it's a big issue though.

@flavens
Copy link
Contributor Author

flavens commented Jan 20, 2021

Looks good to me! One thing to note is that this allows for a few math symbols (÷, ×). Not sure if it's a big issue though.

I do not think so. I am not sure these symbols will ever be used in labels.

@flavens flavens merged commit 8a2654b into main Jan 20, 2021
@flavens flavens deleted the wip/dsp-1241-aalow-accented-character branch January 20, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees

@flavens flavens

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flavens @mdelez