Replace reset buttons with cancel button #284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dasch.myjetbrains.com/youtrack/issue/DSP-546
In this PR I replaced the reset buttons in forms like:
We had some issues with the reset button in combination with stringLiteralInput and list of keywords. So, I replaced reset with cancel which closes the dialog box without doing anything on the form data. I kept the method
reset()
to go back to reset-button and to fix the issues we had. But at the moment I do not have time to fix it. We can discuss if we should get rid of the reset functionality completely... In this case I will try to refactor the relevant forms