Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose GET /admin/projects as ZIO HTTP route (DEV-1587) #2366

Merged
merged 7 commits into from Jan 5, 2023

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Jan 4, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1587

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@swarmia
Copy link

swarmia bot commented Jan 4, 2023

@irinaschubert irinaschubert self-assigned this Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 86.68% // Head: 86.49% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (828e6e3) compared to base (26e9596).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2366      +/-   ##
==========================================
- Coverage   86.68%   86.49%   -0.20%     
==========================================
  Files         250      271      +21     
  Lines       28252    28306      +54     
==========================================
- Hits        24490    24483       -7     
- Misses       3762     3823      +61     
Impacted Files Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.93% <100.00%> (+0.12%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 90.27% <100.00%> (+0.27%) ⬆️
.../scala/org/knora/webapi/responders/Responder.scala 75.00% <0.00%> (-16.43%) ⬇️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 88.27% <0.00%> (-5.79%) ⬇️
...n/scala/org/knora/webapi/routing/HealthRoute.scala 65.30% <0.00%> (-4.51%) ⬇️
.../webapi/messages/util/rdf/jenaimpl/JenaModel.scala 86.42% <0.00%> (-2.86%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 64.93% <0.00%> (-1.74%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 88.72% <0.00%> (-0.80%) ⬇️
...knora/webapi/responders/v1/ValuesResponderV1.scala 92.73% <0.00%> (-0.01%) ⬇️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 93.43% <0.00%> (-0.01%) ⬇️
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irinaschubert irinaschubert marked this pull request as ready for review January 4, 2023 15:32
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cosmetic suggestions from my side

@seakayone seakayone self-requested a review January 5, 2023 10:56
@irinaschubert irinaschubert merged commit b19f81c into main Jan 5, 2023
@irinaschubert irinaschubert deleted the wip/dev-1587-expose-get-all-projects branch January 5, 2023 12:41
@irinaschubert irinaschubert changed the title feat: expose GET /admin/projects as ZIO HTTP route feat: expose GET /admin/projects as ZIO HTTP route (DEV-1587) Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants