Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Spray-JSON with ZIO-JSON in health route #2360

Merged

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Jan 2, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1522

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@linear
Copy link

linear bot commented Jan 2, 2023

DEV-1522 Project Dashboard

As a project member I want to have an overview over my data so that i see what is in my database.

Figma

https://www.figma.com/file/bMCFf5Wcn1XXSrMWyQYvEk/Table-Editor?node-id=496%3A18622

Acceptance Criteria

  • On the Welcome Screen in (DSP-APP) after you logged in there is a Button “Go to Project Dashboard”

  • By clicking the “Go to Project Dashboard”-Button you access the Dashboard

  • By default the first Class in the Ontology is selected and the results für the selected class is shown by default in a List view
    • For the List view the component “Checkbox Group/List item/False/Desktop/with picture” is used
  • It shows 25 results at the first time, if you want to see more you need to click on load more
    • It loading again 25 more results then but the previous results will stay

Detailed description of the List itself you can find here https://dasch.atlassian.net/browse/DEV-644

Navigation_Left

  • Each Tile in the navigation has a subtitle = Name of the class
  • According to the onthology you have an Icon on the Left side
  • Below you have a Link “Add new” name of Resource class"
    • When you click on it will open the form to add a new resource in that class in a full-screen mode
  • You are able to close the menu when you click on the blue chevron-Button
    • The Menu gets smaller and the chevron swith the direction, the add new Buttons will disappear

@swarmia
Copy link

swarmia bot commented Jan 2, 2023

@BalduinLandolt BalduinLandolt self-assigned this Jan 2, 2023
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 86.68% // Head: 86.48% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (f0c1710) compared to base (26e9596).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
- Coverage   86.68%   86.48%   -0.21%     
==========================================
  Files         250      271      +21     
  Lines       28252    28298      +46     
==========================================
- Hits        24490    24473      -17     
- Misses       3762     3825      +63     
Impacted Files Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.93% <100.00%> (+0.12%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 90.27% <100.00%> (+0.27%) ⬆️
.../scala/org/knora/webapi/responders/Responder.scala 75.00% <0.00%> (-16.43%) ⬇️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 88.27% <0.00%> (-5.79%) ⬇️
...n/scala/org/knora/webapi/routing/HealthRoute.scala 65.30% <0.00%> (-4.51%) ⬇️
.../webapi/messages/util/rdf/jenaimpl/JenaModel.scala 86.42% <0.00%> (-2.86%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 64.93% <0.00%> (-1.74%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 88.72% <0.00%> (-0.80%) ⬇️
...knora/webapi/responders/v1/ValuesResponderV1.scala 92.73% <0.00%> (-0.01%) ⬇️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 93.43% <0.00%> (-0.01%) ⬇️
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review January 2, 2023 15:54
@BalduinLandolt BalduinLandolt marked this pull request as draft January 2, 2023 15:55
@BalduinLandolt BalduinLandolt marked this pull request as ready for review January 3, 2023 09:58
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have two zio-fied routes now which do the same - HealthRoute and HealthRouteZ?

@BalduinLandolt
Copy link
Collaborator Author

Don't we have two zio-fied routes now which do the same - HealthRoute and HealthRouteZ?

Not really, one of them still uses Akka HTTP, not ZIO HTTP. But it's true, I could have left spray in the Akka one, I guess. But it shouldn't hurt either

@BalduinLandolt BalduinLandolt merged commit 1b8e74b into main Jan 3, 2023
@BalduinLandolt BalduinLandolt deleted the wip/DEV-1522-replace-spray-json-in-health-route branch January 3, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants