New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace Spray-JSON with ZIO-JSON in health route #2360
refactor: replace Spray-JSON with ZIO-JSON in health route #2360
Conversation
DEV-1522 Project Dashboard
As a project member I want to have an overview over my data so that i see what is in my database. Figma https://www.figma.com/file/bMCFf5Wcn1XXSrMWyQYvEk/Table-Editor?node-id=496%3A18622 Acceptance Criteria
Detailed description of the List itself you can find here https://dasch.atlassian.net/browse/DEV-644 Navigation_Left
|
✅ Linked to Story DEV-1522 · DSP-API: Get rid of SprayJSON and use ZIO JSON instead |
Codecov ReportBase: 86.68% // Head: 86.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
- Coverage 86.68% 86.48% -0.21%
==========================================
Files 250 271 +21
Lines 28252 28298 +46
==========================================
- Hits 24490 24473 -17
- Misses 3762 3825 +63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have two zio-fied routes now which do the same - HealthRoute
and HealthRouteZ
?
Not really, one of them still uses Akka HTTP, not ZIO HTTP. But it's true, I could have left spray in the Akka one, I guess. But it shouldn't hurt either |
Pull Request Checklist
Task Description/Number
Issue Number: DEV-1522
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?