New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove PR2255 plugin and revert project IRIs (DEV-1571) #2350
refactor: remove PR2255 plugin and revert project IRIs (DEV-1571) #2350
Conversation
✅ Linked to Story DEV-1571 · Remove plugin 2255 and revert project IRIs to version with shortcode |
Codecov ReportBase: 86.68% // Head: 86.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
==========================================
- Coverage 86.68% 86.39% -0.30%
==========================================
Files 250 263 +13
Lines 28252 28306 +54
==========================================
- Hits 24490 24454 -36
- Misses 3762 3852 +90
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -209,7 +211,7 @@ follows: | |||
`http://rdfh.ch/projects/PROJECT_SHORTCODE/mappings/MAPPING_NAME` | |||
- XML-to-standoff mapping element: | |||
`http://rdfh.ch/projects/PROJECT_SHORTCODE/mappings/MAPPING_NAME/elements/MAPPING_ELEMENT_UUID` | |||
- Project: `http://rdfh.ch/projects/PROJECT_UUID` | |||
- Project: `http://rdfh.ch/projects/PROJECT_SHORTCODE` (or `http://rdfh.ch/projects/PROJECT_UUID`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "(or http://rdfh.ch/projects/PROJECT_UUID
)" is only valid for the BEOL project, right? (Nothing wrong with it, I just want to make sure that I understood it correctly.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, after revert it's only valid for BEOL, however it also makes open the way to go for new projects having UUID in the IRI instead of the shortcode.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-1571
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?