Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove PR2255 plugin and revert project IRIs (DEV-1571) #2350

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Dec 21, 2022

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1571

  • removed plugin PR2255 and replaced it with Noop plugin - that release contained another change which required a plugin
  • reverted all project IRIs
  • adjusted project IRIs validation
  • refactored some shared test data consts
  • updated docs

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@mpro7 mpro7 self-assigned this Dec 21, 2022
@swarmia
Copy link

swarmia bot commented Dec 21, 2022

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 86.68% // Head: 86.39% // Decreases project coverage by -0.29% ⚠️

Coverage data is based on head (4e6c256) compared to base (26e9596).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
- Coverage   86.68%   86.39%   -0.30%     
==========================================
  Files         250      263      +13     
  Lines       28252    28306      +54     
==========================================
- Hits        24490    24454      -36     
- Misses       3762     3852      +90     
Impacted Files Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.93% <100.00%> (+0.12%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 90.27% <100.00%> (+0.27%) ⬆️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 88.27% <0.00%> (-5.79%) ⬇️
.../webapi/messages/util/rdf/jenaimpl/JenaModel.scala 86.42% <0.00%> (-2.86%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 64.93% <0.00%> (-1.74%) ⬇️
...ebapi/store/cache/impl/CacheServiceRedisImpl.scala 56.12% <0.00%> (-1.16%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 88.72% <0.00%> (-0.80%) ⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...ain/scala/org/knora/webapi/routing/ApiRoutes.scala 100.00% <0.00%> (ø)
...ebapi/store/cache/impl/CacheServiceInMemImpl.scala 100.00% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpro7 mpro7 changed the title revert project IRIs refactor: remove PR2255 plugin and revert project IRIs Dec 21, 2022
@mpro7 mpro7 marked this pull request as ready for review December 21, 2022 15:29
@mpro7 mpro7 changed the title refactor: remove PR2255 plugin and revert project IRIs refactor: remove PR2255 plugin and revert project IRIs (DEV-1571) Dec 21, 2022
@@ -209,7 +211,7 @@ follows:
`http://rdfh.ch/projects/PROJECT_SHORTCODE/mappings/MAPPING_NAME`
- XML-to-standoff mapping element:
`http://rdfh.ch/projects/PROJECT_SHORTCODE/mappings/MAPPING_NAME/elements/MAPPING_ELEMENT_UUID`
- Project: `http://rdfh.ch/projects/PROJECT_UUID`
- Project: `http://rdfh.ch/projects/PROJECT_SHORTCODE` (or `http://rdfh.ch/projects/PROJECT_UUID`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "(or http://rdfh.ch/projects/PROJECT_UUID)" is only valid for the BEOL project, right? (Nothing wrong with it, I just want to make sure that I understood it correctly.)

Copy link
Collaborator Author

@mpro7 mpro7 Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, after revert it's only valid for BEOL, however it also makes open the way to go for new projects having UUID in the IRI instead of the shortcode.

@mpro7 mpro7 merged commit 86a19ab into main Dec 22, 2022
@mpro7 mpro7 deleted the DEV-1571-remove-plugin-2255-and-revert-project-ir-is-to-version-with-shortcode branch December 22, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants