Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor project route for ZIO HTTP #2338

Merged
merged 34 commits into from Dec 15, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Dec 13, 2022

Pull Request Checklist

Task Description/Number

This branch is the result of a mob programming session to refactor a route for use with ZIO HTTP.

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

seakayone and others added 30 commits December 12, 2022 21:27
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/core/HttpServerWithZIOHttp.scala
lastFile:webapi/src/main/scala/org/knora/webapi/routing/admin/ProjectsRouteZ.scala
lastFile:webapi/src/main/scala/org/knora/webapi/http/status/ApiStatusCodesZ.scala
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 86.68% // Head: 86.55% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (2a0563d) compared to base (26e9596).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 2a0563d differs from pull request most recent head 7889986. Consider uploading reports for the commit 7889986 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   86.68%   86.55%   -0.13%     
==========================================
  Files         250      253       +3     
  Lines       28252    28294      +42     
==========================================
  Hits        24490    24490              
- Misses       3762     3804      +42     
Impacted Files Coverage Δ
...main/scala/org/knora/webapi/core/HttpServerZ.scala 0.00% <0.00%> (ø)
.../knora/webapi/http/handler/ExceptionHandlerZ.scala 0.00% <0.00%> (ø)
...org/knora/webapi/http/status/ApiStatusCodesZ.scala 0.00% <0.00%> (ø)
.../scala/org/knora/webapi/routing/HealthRouteZ.scala 0.00% <ø> (ø)
...rg/knora/webapi/routing/admin/ProjectsRouteZ.scala 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irinaschubert irinaschubert marked this pull request as ready for review December 15, 2022 08:55
@irinaschubert irinaschubert merged commit e5be1db into main Dec 15, 2022
@irinaschubert irinaschubert deleted the wip/refactor-project-route-for-zio-http branch December 15, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants