New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: return external representation of ontology IRIs in admin routes (DEV-974) #2330
fix!: return external representation of ontology IRIs in admin routes (DEV-974) #2330
Conversation
✅ Linked to Story DEV-974 · DSP-API: Use external ontology IRIs in admin route responses |
PR Progress / TODO
|
Codecov ReportBase: 86.68% // Head: 86.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
- Coverage 86.68% 86.48% -0.20%
==========================================
Files 250 271 +21
Lines 28252 28302 +50
==========================================
- Hits 24490 24478 -12
- Misses 3762 3824 +62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ervice as dedicated service allowing for breaking up the inheritance hierachy
…tps://github.com/dasch-swiss/dsp-api into wip/DEV-974-return-external-iris-in-admin-routes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to approve, but GutHub doesn't let me because it considers me an author of the PR
webapi/src/it/scala/org/knora/webapi/responders/admin/PermissionsResponderADMSpec.scala
Outdated
Show resolved
Hide resolved
…onsResponderADMSpec.scala Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Show resolved
Hide resolved
LGTM, just some minor coding style comments. Feel free to ignore them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, removed a lot of dead code :)
webapi/src/main/scala/org/knora/webapi/responders/admin/PermissionsResponderADM.scala
Outdated
Show resolved
Hide resolved
…sionsResponderADM.scala Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
Pull Request Checklist
Task Description/Number
Issue Number: DEV-974
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?