Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: return external representation of ontology IRIs in admin routes (DEV-974) #2330

Merged
merged 58 commits into from Jan 3, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Dec 7, 2022

Pull Request Checklist

Task Description/Number

Issue Number: DEV-974

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@swarmia
Copy link

swarmia bot commented Dec 7, 2022

@BalduinLandolt BalduinLandolt self-assigned this Dec 7, 2022
@BalduinLandolt
Copy link
Collaborator Author

BalduinLandolt commented Dec 7, 2022

PR Progress / TODO

  • projects endpoint
  • user endpoint
  • groups endpoint
  • list endpoint
  • permissions endpoint

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 86.68% // Head: 86.48% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (ad74065) compared to base (26e9596).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   86.68%   86.48%   -0.20%     
==========================================
  Files         250      271      +21     
  Lines       28252    28302      +50     
==========================================
- Hits        24490    24478      -12     
- Misses       3762     3824      +62     
Impacted Files Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.93% <100.00%> (+0.12%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 90.27% <100.00%> (+0.27%) ⬆️
.../scala/org/knora/webapi/responders/Responder.scala 75.00% <0.00%> (-16.43%) ⬇️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 88.27% <0.00%> (-5.79%) ⬇️
.../webapi/messages/util/rdf/jenaimpl/JenaModel.scala 86.42% <0.00%> (-2.86%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 64.93% <0.00%> (-1.74%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 88.72% <0.00%> (-0.80%) ⬇️
...knora/webapi/responders/v1/ValuesResponderV1.scala 92.73% <0.00%> (-0.01%) ⬇️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 93.43% <0.00%> (-0.01%) ⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BalduinLandolt BalduinLandolt changed the title comment out potentially unused message and receive method for it refactor(admin): return external representation of IRIs in admin routes Dec 7, 2022
@irinaschubert irinaschubert self-assigned this Dec 14, 2022
@irinaschubert irinaschubert changed the title refactor!: return external representation of ontology IRIs in admin routes fix!: return external representation of ontology IRIs in admin routes Dec 22, 2022
Copy link
Collaborator Author

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to approve, but GutHub doesn't let me because it considers me an author of the PR

irinaschubert and others added 5 commits January 3, 2023 10:02
@seakayone
Copy link
Collaborator

LGTM, just some minor coding style comments. Feel free to ignore them.

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, removed a lot of dead code :)

irinaschubert and others added 2 commits January 3, 2023 11:08
@irinaschubert irinaschubert merged commit b58828a into main Jan 3, 2023
@irinaschubert irinaschubert deleted the wip/DEV-974-return-external-iris-in-admin-routes branch January 3, 2023 14:57
@daschbot daschbot mentioned this pull request Jan 3, 2023
@irinaschubert irinaschubert changed the title fix!: return external representation of ontology IRIs in admin routes fix!: return external representation of ontology IRIs in admin routes (DEV-974) Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants