Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused route GET /admin/stores #2329

Merged
merged 1 commit into from Dec 7, 2022

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Dec 7, 2022

Pull Request Checklist

Task Description/Number

GET /admin/stores route stub has never been implemented and ever only returned "Hello World". I removed it now.

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@BalduinLandolt BalduinLandolt self-assigned this Dec 7, 2022
@BalduinLandolt BalduinLandolt changed the title remove unused route chore: remove unused route GET /admin/stores Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 5.23% // Head: 86.65% // Increases project coverage by +81.41% 🎉

Coverage data is based on head (68588fd) compared to base (cedb603).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #2329       +/-   ##
==========================================
+ Coverage   5.23%   86.65%   +81.41%     
==========================================
  Files        251      251               
  Lines      28266    28263        -3     
==========================================
+ Hits        1481    24490    +23009     
+ Misses     26785     3773    -23012     
Impacted Files Coverage Δ
...org/knora/webapi/routing/admin/StoreRouteADM.scala 100.00% <100.00%> (+100.00%) ⬆️
...g/knora/webapi/responders/v1/CkanResponderV1.scala 0.70% <0.00%> (+0.70%) ⬆️
...hared/src/main/scala/dsp/valueobjects/Schema.scala 99.04% <0.00%> (+0.95%) ⬆️
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.81% <0.00%> (+2.06%) ⬆️
...la/org/knora/webapi/routing/v1/AssetsRouteV1.scala 4.76% <0.00%> (+4.76%) ⬆️
...rc/main/scala/org/knora/webapi/RdfMediaTypes.scala 97.22% <0.00%> (+5.55%) ⬆️
...knora/webapi/routing/v1/ResourceTypesRouteV1.scala 8.69% <0.00%> (+8.69%) ⬆️
...cala/org/knora/webapi/routing/v1/CkanRouteV1.scala 9.09% <0.00%> (+9.09%) ⬆️
...knora/webapi/store/triplestore/errors/Errors.scala 12.50% <0.00%> (+12.50%) ⬆️
.../store/triplestore/upgrade/RepositoryUpdater.scala 14.10% <0.00%> (+14.10%) ⬆️
... and 195 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BalduinLandolt BalduinLandolt merged commit 1e11655 into main Dec 7, 2022
@BalduinLandolt BalduinLandolt deleted the wip/remove-route-stub-get-admin-stores branch December 7, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants