New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add GH workflow to publish manually from branches #2316
chore: add GH workflow to publish manually from branches #2316
Conversation
✅ Linked to Story DEV-1519 · DSP-API: make possible to publish manually to DockerHub using GH Actions |
…nually-to-docker-hub-using-gh-actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -3,7 +3,6 @@ name: Publish | |||
on: | |||
release: | |||
types: [published] | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: what is the reason to remove this? Don't you think it might be useful to keep it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it on the previous attempt thinking we can use this workflow to release on demand manually, but apparently it didn't work, so I remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for the clarification
Codecov ReportBase: 86.95% // Head: 86.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
- Coverage 86.95% 86.68% -0.28%
==========================================
Files 242 251 +9
Lines 28102 28253 +151
==========================================
+ Hits 24435 24490 +55
- Misses 3667 3763 +96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Pull Request Checklist
Task Description/Number
Issue Number: DEV-1519
Another attempt to have possibility to publish to Docker Hub manually.
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?