New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix RepositoryUpdater that is not timing out during repository upgrade (DEV-1534) #2313
fix: fix RepositoryUpdater that is not timing out during repository upgrade (DEV-1534) #2313
Conversation
✅ Linked to Story DEV-1534 · DSP-API: Fix upgrade plugin that is able to dump DB during repository upgrade |
…able-to-dump-db-during-repository-upgrade
Codecov ReportBase: 86.95% // Head: 86.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2313 +/- ##
==========================================
- Coverage 86.95% 86.64% -0.31%
==========================================
Files 242 251 +9
Lines 28102 28266 +164
==========================================
+ Hits 24435 24490 +55
- Misses 3667 3776 +109
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not touching this PR so late in the evening, and tomorrow I'm off. But one thing caught my eye: the file webapi/src/main/resources/fuseki-repository-config.ttl.template
was only necessary after deleting the DB, which is no longer done. So this file should be removed, I think.
…able-to-dump-db-during-repository-upgrade
You are absolutely right. The file was removed. |
Issue Number: DEV-1534
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?
Other information