Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix RepositoryUpdater that is not timing out during repository upgrade (DEV-1534) #2313

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Nov 29, 2022

Issue Number: DEV-1534

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@mpro7 mpro7 self-assigned this Nov 29, 2022
@swarmia
Copy link

swarmia bot commented Nov 29, 2022

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 86.95% // Head: 86.64% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (6ca5072) compared to base (bfe578a).
Patch coverage: 41.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2313      +/-   ##
==========================================
- Coverage   86.95%   86.64%   -0.31%     
==========================================
  Files         242      251       +9     
  Lines       28102    28266     +164     
==========================================
+ Hits        24435    24490      +55     
- Misses       3667     3776     +109     
Impacted Files Coverage Δ
...ain/scala/dsp/project/handler/ProjectHandler.scala 100.00% <ø> (ø)
.../src/main/scala/dsp/role/handler/RoleHandler.scala 88.00% <ø> (ø)
...c/main/scala/dsp/role/repo/impl/RoleRepoLive.scala 100.00% <ø> (ø)
...shared/src/main/scala/dsp/util/UuidGenerator.scala 0.00% <0.00%> (ø)
...erface/src/main/scala/dsp/user/route/GetUser.scala 0.00% <0.00%> (ø)
...ce/src/main/scala/dsp/user/route/MigrateUser.scala 0.00% <0.00%> (ø)
...ace/src/main/scala/dsp/user/route/UserRoutes.scala 0.00% <0.00%> (ø)
...c/main/scala/dsp/user/repo/impl/UserRepoLive.scala 100.00% <ø> (ø)
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...main/scala/org/knora/webapi/config/AppConfig.scala 81.63% <ø> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpro7 mpro7 changed the title Dev 1534 dsp api fix upgrade plugin that is able to dump db during repository upgrade fix: fix plugin that is not timing out during repository upgrade (DEV-1534) Dec 1, 2022
@mpro7 mpro7 marked this pull request as ready for review December 1, 2022 17:03
@mpro7 mpro7 changed the title fix: fix plugin that is not timing out during repository upgrade (DEV-1534) fix: fix RepositoryUpdated that is not timing out during repository upgrade (DEV-1534) Dec 1, 2022
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not touching this PR so late in the evening, and tomorrow I'm off. But one thing caught my eye: the file webapi/src/main/resources/fuseki-repository-config.ttl.template was only necessary after deleting the DB, which is no longer done. So this file should be removed, I think.

@mpro7
Copy link
Collaborator Author

mpro7 commented Dec 1, 2022

I'm not touching this PR so late in the evening, and tomorrow I'm off. But one thing caught my eye: the file webapi/src/main/resources/fuseki-repository-config.ttl.template was only necessary after deleting the DB, which is no longer done. So this file should be removed, I think.

You are absolutely right. The file was removed.

@mpro7 mpro7 changed the title fix: fix RepositoryUpdated that is not timing out during repository upgrade (DEV-1534) fix: fix RepositoryUpdater that is not timing out during repository upgrade (DEV-1534) Dec 1, 2022
@seakayone seakayone merged commit 213a5f0 into main Dec 2, 2022
@seakayone seakayone deleted the DEV-1534-dsp-api-fix-upgrade-plugin-that-is-able-to-dump-db-during-repository-upgrade branch December 2, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants