New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Deprecation warnings for SCryptPasswordEncoder #2308
Conversation
Codecov ReportBase: 86.95% // Head: 86.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2308 +/- ##
==========================================
- Coverage 86.95% 86.68% -0.28%
==========================================
Files 242 251 +9
Lines 28102 28253 +151
==========================================
+ Hits 24435 24490 +55
- Misses 3667 3763 +96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing some context here (might be a case for a sentence of description in the PR template?)
I updated it. |
Issue Number: DEV-
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?
Other information
There were deprecation warnings for creating an instance of
SCryptPasswordEncoder
without explicit parameters. So, I made the default parameters that were so far set in the background explicit.