New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove Redis cache implementation leftovers (DEV-1503) #2290
Conversation
✅ Linked to Story DEV-1503 · DSP-API: Remove Redis related implementation leftovers |
Codecov ReportBase: 86.68% // Head: 86.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2290 +/- ##
==========================================
- Coverage 86.68% 86.47% -0.21%
==========================================
Files 250 267 +17
Lines 28252 28215 -37
==========================================
- Hits 24490 24399 -91
- Misses 3762 3816 +54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more occurences of Redis floating around, I was just working sth in the configuration (AppConfig and application.conf) and in there is Redis related stuff, too. Also in the docs, probably.
I would suggest to also take the word "cache" into the PR title (in case we search for it in the future).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d1a9d4c
to
f4b1c6b
Compare
Issue Number: DEV-1503
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?
Other information