Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Redis cache implementation leftovers (DEV-1503) #2290

Merged
merged 6 commits into from Jan 2, 2023

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Nov 18, 2022

Issue Number: DEV-1503

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@swarmia
Copy link

swarmia bot commented Nov 18, 2022

@mpro7 mpro7 self-assigned this Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 86.68% // Head: 86.47% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (b320a0e) compared to base (26e9596).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
- Coverage   86.68%   86.47%   -0.21%     
==========================================
  Files         250      267      +17     
  Lines       28252    28215      -37     
==========================================
- Hits        24490    24399      -91     
- Misses       3762     3816      +54     
Impacted Files Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.93% <100.00%> (+0.12%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 90.27% <100.00%> (+0.27%) ⬆️
.../scala/org/knora/webapi/responders/Responder.scala 75.00% <0.00%> (-16.43%) ⬇️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 88.27% <0.00%> (-5.79%) ⬇️
.../webapi/messages/util/rdf/jenaimpl/JenaModel.scala 86.42% <0.00%> (-2.86%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 64.93% <0.00%> (-1.74%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 88.72% <0.00%> (-0.80%) ⬇️
...api/responders/admin/PermissionsResponderADM.scala 90.16% <0.00%> (-0.04%) ⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...main/scala/org/knora/webapi/settings/package.scala 100.00% <0.00%> (ø)
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpro7 mpro7 marked this pull request as ready for review November 18, 2022 15:07
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more occurences of Redis floating around, I was just working sth in the configuration (AppConfig and application.conf) and in there is Redis related stuff, too. Also in the docs, probably.

I would suggest to also take the word "cache" into the PR title (in case we search for it in the future).

@mpro7 mpro7 marked this pull request as draft November 18, 2022 15:44
@mpro7 mpro7 changed the title refactor: remove Redis related implementation leftovers (DEV-1503) refactor: remove Redis cache related implementation leftovers (DEV-1503) Nov 18, 2022
@mpro7 mpro7 marked this pull request as ready for review November 21, 2022 06:14
@mpro7 mpro7 changed the title refactor: remove Redis cache related implementation leftovers (DEV-1503) refactor: remove Redis cache implementation leftovers (DEV-1503) Nov 21, 2022
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpro7 mpro7 removed the request for review from subotic November 30, 2022 13:52
@mpro7 mpro7 force-pushed the DEV-1503-dsp-api-remove-cache-service-redis-impl branch from d1a9d4c to f4b1c6b Compare January 2, 2023 12:51
@mpro7 mpro7 merged commit a678dc5 into main Jan 2, 2023
@mpro7 mpro7 deleted the DEV-1503-dsp-api-remove-cache-service-redis-impl branch January 2, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants