Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase timeout when emptying repository (DEV-1506) #2289

Merged
merged 2 commits into from Nov 18, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Nov 17, 2022

Issue Number: DEV-1506

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@swarmia
Copy link

swarmia bot commented Nov 17, 2022

@irinaschubert irinaschubert self-assigned this Nov 17, 2022
@irinaschubert irinaschubert marked this pull request as ready for review November 17, 2022 17:03
@irinaschubert irinaschubert changed the title fix: increase timeout when emptying repository (DEV-1506) fix: Increase timeout when emptying repository (DEV-1506) Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 86.85% // Head: 86.95% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (862574d) compared to base (c5c98ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
+ Coverage   86.85%   86.95%   +0.09%     
==========================================
  Files         241      242       +1     
  Lines       27967    28102     +135     
==========================================
+ Hits        24292    24435     +143     
+ Misses       3675     3667       -8     
Impacted Files Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 94.68% <100.00%> (+0.36%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 90.00% <100.00%> (+5.94%) ⬆️
.../knora/webapi/routing/admin/ProjectsRouteADM.scala 93.10% <0.00%> (-4.27%) ⬇️
...sp-shared/src/main/scala/dsp/valueobjects/Id.scala 65.38% <0.00%> (-3.85%) ⬇️
...n/scala/org/knora/webapi/routing/HealthRoute.scala 69.81% <0.00%> (-1.89%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 89.36% <0.00%> (-0.81%) ⬇️
...r/permissionsmessages/PermissionsMessagesADM.scala 86.39% <0.00%> (-0.32%) ⬇️
...ages/util/search/gravsearch/GravsearchParser.scala 68.13% <0.00%> (-0.26%) ⬇️
...scala/org/knora/webapi/routing/Authenticator.scala 88.88% <0.00%> (-0.08%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpro7 mpro7 merged commit 39771ed into main Nov 18, 2022
@mpro7 mpro7 deleted the wip/dev-1506-increase-timeout-emptying-repository branch November 18, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants